Add Record class, DID Manager, and Stabilize API #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Hinek <[email protected]>
frankhinek
force-pushed
the
feat/record-class
branch
from
4362ce2 to
97346e1
Compare
Caused by git ignoring case
Caused by git ignoring case
michaelneale
approved these changes
Apr 20, 2023
dcrousso
previously requested changes
Apr 20, 2023
mistermoe
reviewed
Apr 20, 2023
|
The style changes seem consistent with https://google.github.io/styleguide/jsguide.html#naming-camel-case-defined - which is more rigorous thing I can find out there (took me a while to dig it up from memory).
|
mistermoe
reviewed
Apr 20, 2023
…k to 422 Co-authored-by: Frank Hinek <[email protected]> Co-authored-by: Devin Rousso <[email protected]>
@michaelneale FWIW, this also isn't introducing anything new that wasn't already the case in |
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
… type Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
frankhinek
force-pushed
the
feat/record-class
branch
from
96c7a80 to
9870e2f
Compare
…HTTP transport Signed-off-by: Frank Hinek <[email protected]>
frankhinek
dismissed
dcrousso’s stale review
All suggestions incorporated, commented on, or new issues opened.
Signed-off-by: Frank Hinek <[email protected]>
csuwildcat
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External API changes
web5.did.register()withweb5.did.manager()Recordclass which greatly improves the developer experience and makes working with records and record data significantly easier.web5.dwn.records.createFrom()as a convenience to make it easy to create a new record based on an existing record.web5.dwn.records.create()which is an alias forweb5.dwn.records.write()Internal function changes:
#createSignedMessage()now takes anauthorparameter which removes redundant data from being stored by the DidManager and a pre-req for future improvements to key management.https://github.com/TBD54566975/web5-js/blob/4362ce22d5ea77c280c1e6eb17726b6a37af51de/src/Web5.js#L80
deletemethods onStorageclass and inherited classes withremoveto make it possible to create functional storage adapters (deleteis a reserved word if used outside of class methods).Chores/Cleanup
dwnkey ID by default for ION dids created withweb5.did.create()https://github.com/TBD54566975/web5-js/blob/4362ce22d5ea77c280c1e6eb17726b6a37af51de/src/did/methods/ion.js#L9keypair/keyPairdiscrepancy raised in case issue: keypair vs keyPair #35dwn-sdk-jsdwn-sdk-jsNote to @TBD54566975/tbd-developer-relations:
examples/directory, which are currently used for validating/testing during development